Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general/bool: Remove TRUE/FALSE and boolean-style uses with int types #9804

Closed
wants to merge 11 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #9671

Describe changes:

  • Remove TRUE/FALSE and replace with logic/code using bool native types

Updates:

  • Rebase

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #9804 (3117d70) into master (2f4027c) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9804      +/-   ##
==========================================
- Coverage   82.37%   82.36%   -0.01%     
==========================================
  Files         968      968              
  Lines      273866   273853      -13     
==========================================
- Hits       225585   225561      -24     
- Misses      48281    48292      +11     
Flag Coverage Δ
fuzzcorpus 64.21% <39.13%> (+<0.01%) ⬆️
suricata-verify 60.96% <75.36%> (-0.02%) ⬇️
unittests 62.94% <30.43%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Nov 17, 2023
This was referenced Nov 17, 2023
@victorjulien
Copy link
Member

Merged in #9829, thanks!

@jlucovsky jlucovsky deleted the bool/4 branch November 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants