-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform: Add case-changing transforms #9761
Conversation
Add the constants for the to_lowercase and to_uppercase transforms Issue: 6439
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9761 +/- ##
==========================================
- Coverage 82.56% 82.39% -0.18%
==========================================
Files 968 968
Lines 273827 273827
==========================================
- Hits 226074 225607 -467
- Misses 47753 48220 +467
Flags with carried forward coverage won't be shown. Click here to find out more. |
Missing SV test ;-p |
This commit adds the implementation for the case changing transforms: to_lowercase and to_uppercase Issue: 6439
I think we should reject a sig like |
Information: QA ran without warnings. Pipeline 16438 |
Good point. Would you like that addressed in this PR or a separate one? |
Good point. I'll update the PR with additional validation checks. |
Continued in #9786 |
DRAFT: suricata-verify tests will be added soon
Add the transforms for changing the case of a buffer.
Link to redmine ticket: (6439)[https://redmine.openinfosecfoundation.org/issues/6439]
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/N
whereN
is thepull request number.
Alternatively,
SV_BRANCH
may also be a link to anOISF/suricata-verify pull-request.