-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multipart mime 3487 v20 #9437
Multipart mime 3487 v20 #9437
Conversation
Accepts escaped quote in escaped string
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 15822 |
} | ||
|
||
#[no_mangle] | ||
pub unsafe extern "C" fn rs_mime_smtp_state_init( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public C API so should follow those naming conventions prefixed with SC
. See rust/src/ffi/hashing.rs
as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all git grep 'pub unsafe extern "C"' rust/src/mime/
?
Only for new ones ?
(I see that http2 for instance has the same rs_http_parse_content_range
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for new ones ?
New for sure. As this is targetting 8, I'd say for all tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit pushed in my branch multipart-mime-3487-v23 ;-)
Replaced by #9443 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #9436 with fix for not taking the en d of line before the boundary as part of the file
SV tests from unit tests in OISF/suricata-verify#1371
Draft :