Multipart mime 3487 v20 #9437
Closed
Multipart mime 3487 v20 #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts escaped quote in escaped string
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 15822 |
jasonish
reviewed
Sep 5, 2023
| } | ||
|
|
||
| #[no_mangle] | ||
| pub unsafe extern "C" fn rs_mime_smtp_state_init( |
There was a problem hiding this comment.
Public C API so should follow those naming conventions prefixed with SC. See rust/src/ffi/hashing.rs as an example.
There was a problem hiding this comment.
For all git grep 'pub unsafe extern "C"' rust/src/mime/ ?
Only for new ones ?
(I see that http2 for instance has the same rs_http_parse_content_range)
There was a problem hiding this comment.
Only for new ones ?
New for sure. As this is targetting 8, I'd say for all tho.
There was a problem hiding this comment.
Commit pushed in my branch multipart-mime-3487-v23 ;-)
|
Replaced by #9443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #9436 with fix for not taking the en d of line before the boundary as part of the file
SV tests from unit tests in OISF/suricata-verify#1371
Draft :