Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update file keywords v2 #9316

Closed

Conversation

jmtaylor90
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

  • Update file.magic and file.name keyword information to reflect recent updates
  • Update libmagic dependency information and reference
  • Address comments in doc: update file keywords v1 #9245

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Signed-off-by: jason taylor <jtfas90@gmail.com>
Signed-off-by: jason taylor <jtfas90@gmail.com>
Signed-off-by: jason taylor <jtfas90@gmail.com>
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that this has addressed Victor's comments from previous PR.
Wondering a bit if we should reword where it's stated that the only difference between legacy and new keywords is the nocase, since the keyword syntax seems to be slightly different...

@jmtaylor90
Copy link
Contributor Author

Seems to me that this has addressed Victor's comments from previous PR. Wondering a bit if we should reword where it's stated that the only difference between legacy and new keywords is the nocase, since the keyword syntax seems to be slightly different...

Sure, I will take another look at how those section(s) are worded.

@jmtaylor90 jmtaylor90 mentioned this pull request Aug 2, 2023
3 tasks
@jmtaylor90
Copy link
Contributor Author

continued in #9327

@jmtaylor90 jmtaylor90 closed this Aug 2, 2023
@jmtaylor90 jmtaylor90 deleted the doc-update-file-keywords-v2 branch August 8, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants