-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verdict eve field - 6.0.x backports - v3 #9311
Conversation
The `field action` portion seemed to be comprised of a more generic section that followed it. Also formatted the section for lines to be within the character limit. (cherry picked from commit 9900bdc)
Information:
Pipeline 15461 |
@@ -572,6 +573,68 @@ static void AlertAddFiles(const Packet *p, JsonBuilder *jb, const uint64_t tx_id | |||
} | |||
} | |||
|
|||
bool PacketCheckAction(const Packet *p, const uint8_t a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in master 6 we have been fixing things differently, I think you should use PACKET_TEST_ACTION
instead
@@ -250,6 +254,9 @@ outputs: | |||
# alerts: yes # log alerts that caused drops | |||
# flows: all # start or all: 'start' logs only a single drop | |||
# # per flow direction. All logs each dropped pkt. | |||
# Enable logging the final action taken on a packet by the engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the github review view this looks odd wrt formatting
Feedback incorporated in #9318 |
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5794
Previous PR: #9309
Describe changes:
SV_BRANCH=pr/1336
OISF/suricata-verify#1336