verdict eve field - 6.0.x backports - v3 #9311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `field action` portion seemed to be comprised of a more generic section that followed it. Also formatted the section for lines to be within the character limit. (cherry picked from commit 9900bdc)
|
Information:
Pipeline 15461 |
victorjulien
reviewed
Aug 1, 2023
| @@ -572,6 +573,68 @@ static void AlertAddFiles(const Packet *p, JsonBuilder *jb, const uint64_t tx_id | |||
| } | |||
| } | |||
|
|
|||
| bool PacketCheckAction(const Packet *p, const uint8_t a) | |||
There was a problem hiding this comment.
in master 6 we have been fixing things differently, I think you should use PACKET_TEST_ACTION instead
victorjulien
reviewed
Aug 1, 2023
| @@ -250,6 +254,9 @@ outputs: | |||
| # alerts: yes # log alerts that caused drops | |||
| # flows: all # start or all: 'start' logs only a single drop | |||
| # # per flow direction. All logs each dropped pkt. | |||
| # Enable logging the final action taken on a packet by the engine | |||
There was a problem hiding this comment.
in the github review view this looks odd wrt formatting
|
Feedback incorporated in #9318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5794
Previous PR: #9309
Describe changes:
SV_BRANCH=pr/1336
OISF/suricata-verify#1336