Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/userguide: improve SCStreamingBuffer example #9302

Closed
wants to merge 1 commit into from

Conversation

erdnaxe
Copy link
Contributor

@erdnaxe erdnaxe commented Jul 28, 2023

Add direction indication in SCStreamingBuffer usage example.
This adds documentation for the changes introduced by commit 5b1d8c7.

Link to redmine ticket: none

Describe changes:

  • Improve Lua API SCStreamingBuffer() documentation

Add direction indication in SCStreamingBuffer usage example.
This adds documentation for the changes introduced by commit
5b1d8c7.
@github-actions
Copy link

NOTE: This PR may contain new authors:

Alexandre Iooss <erdnaxe@crans.org>

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #9302 (15ad513) into master (8770431) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9302      +/-   ##
==========================================
- Coverage   82.42%   82.41%   -0.01%     
==========================================
  Files         968      968              
  Lines      274011   274015       +4     
==========================================
- Hits       225845   225836       -9     
- Misses      48166    48179      +13     
Flag Coverage Δ
fuzzcorpus 64.64% <ø> (-0.01%) ⬇️
suricata-verify 60.83% <ø> (-0.02%) ⬇️
unittests 62.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the typo/doc update No code change : only doc or typo fixes label Jul 28, 2023
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful addition, thanks! :)

@victorjulien
Copy link
Member

Merged in #9355, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

3 participants