Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general/bool: Remove TRUE/FALSE and boolean-style uses with int types #9298

Closed
wants to merge 12 commits into from
Closed

general/bool: Remove TRUE/FALSE and boolean-style uses with int types #9298

wants to merge 12 commits into from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Jul 27, 2023 •
edited
Loading

Describe changes:

  • Remove libnss from CI steps
  • Remove TRUE/FALSE and replace with logic/code using bool native types

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@jlucovsky jlucovsky marked this pull request as ready for review July 27, 2023 18:38
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 15408

@victorjulien victorjulien added this to the 8.0 milestone Jul 28, 2023
catenacyber
catenacyber reviewed Aug 30, 2023
View reviewed changes
.github/workflows/builds.yml
@@ -2095,7 +2095,6 @@ jobs:
libjansson-dev \
libjansson4 \
liblua5.1-dev \
libnss3-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that :-)

@catenacyber
Copy link
Contributor

Is there a ticket for this ?

@jlucovsky
Copy link
Contributor Author

Is there a ticket for this ?

No, I haven't created one yet.

@catenacyber catenacyber mentioned this pull request Sep 6, 2023
Merged
@jlucovsky jlucovsky mentioned this pull request Oct 21, 2023
Closed
@jlucovsky
Copy link
Contributor Author

Continued in #9671

@jlucovsky jlucovsky closed this Oct 21, 2023
@jlucovsky jlucovsky deleted the bool/1 branch November 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber left review comments

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jlucovsky @suricata-qa @catenacyber @victorjulien