IPS stats/v3 #9285
Closed
IPS stats/v3 #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since many implementations use the ReleasePacket callback to issue their verdict, no thread ctx is available. To work around this just register the stats in a `thread_local` variable instead.
ReleasePacket based verdicts can happen in several threads, depending on the runmode details. Only register and update if in IPS mode.
This adds support to all capture methods for these counters. Ticket: OISF#4756.
{
"accepted": 296185,
"blocked": 162,
"rejected": 0,
"replaced": 0,
"drop_reason": {
"decode_error": 0,
"defrag_error": 0,
"defrag_memcap": 0,
"flow_memcap": 0,
"flow_drop": 94,
"applayer_error": 0,
"applayer_memcap": 0,
"rules": 3,
"threshold_detection_filter": 0,
"stream_error": 63,
"stream_memcap": 0,
"stream_midstream": 2,
"nfq_error": 0,
"tunnel_packet_drop": 0
}
}
Ticket: OISF#6230.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9285 +/- ##
==========================================
- Coverage 82.43% 82.40% -0.03%
==========================================
Files 968 968
Lines 273953 274004 +51
==========================================
- Hits 225840 225806 -34
- Misses 48113 48198 +85
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
|
Information: QA ran without warnings. Pipeline 15384 |
jufajardini
reviewed
Jul 25, 2023
| @@ -403,6 +403,7 @@ enum PacketDropReason { | |||
| PKT_DROP_REASON_STREAM_MIDSTREAM, | |||
| PKT_DROP_REASON_NFQ_ERROR, /**< no nfq verdict, must be error */ | |||
| PKT_DROP_REASON_INNER_PACKET, /**< drop issued by inner (tunnel) packet */ | |||
| PKT_DROP_REASON_MAX, | |||
There was a problem hiding this comment.
If the idea is to help users figure out what's happening, wouldn't it make sense to have a drop reason specifically for stream reassembly memcap?
There was a problem hiding this comment.
yeah agree, but that is outside of the scope of this PR. Can you do a ticket for that?
There was a problem hiding this comment.
|
Would be good to have an SV test showcasing these new stats counters. I could take that up. |
Merged
|
Merged in #9288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ "accepted": 301661, "blocked": 219, "rejected": 0, "replaced": 0, "drop_reason": { "decode_error": 0, "defrag_error": 0, "defrag_memcap": 0, "flow_memcap": 0, "flow_drop": 143, "applayer_error": 0, "applayer_memcap": 0, "rules": 3, "threshold_detection_filter": 0, "stream_error": 68, "stream_memcap": 0, "stream_midstream": 5, "nfq_error": 0, "tunnel_packet_drop": 0 } }https://redmine.openinfosecfoundation.org/issues/4756
https://redmine.openinfosecfoundation.org/issues/6230
replaces #9284, fixing counters updates