radix: Don't leak memory when key can't be added #9273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that memory for the reputation key is released on failed adds. Contributed by Giuseppe Longo <giuseppe@glongo.it> Issue: 5748
This commit converts usages of `int` to `bool` within the radix utility code.
Issue: 5748 This commit adds SC_EEXIST to be used for cases where an item/resource/artifact with the same attributes already exists.
This commit prevents duplicate IPV4/IPV6 netblocks from being added to the radix tree. Contributed by Giuseppe Longo <giuseppe@glongo.it> Issue: 5748
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9273 +/- ##
==========================================
- Coverage 82.42% 78.64% -3.79%
==========================================
Files 968 968
Lines 273952 273797 -155
==========================================
- Hits 225807 215319 -10488
- Misses 48145 58478 +10333
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 15355 |
victorjulien
requested changes
Jul 24, 2023
| @@ -484,11 +482,13 @@ void SCRadixReleaseRadixTree(SCRadixTree *tree) | |||
| * this key | |||
| * \param netmask The netmask (cidr) if we are adding an IP netblock; 255 | |||
| * if we are not adding an IP netblock | |||
| * \param exclusive True (false) if the node should added if not present (present). | |||
There was a problem hiding this comment.
I have a bit of trouble parsing this... what is True (false) and present (present)?
There was a problem hiding this comment.
I'll reword this and will repost.
|
|
||
| memset(tmp_stream, 0, 255); | ||
| // memset(tmp_stream, 0, 255); |
|
Continued in #9280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9264
Thanks to @glongo for the contributions included in the redmine ticket.
Link to redmine ticket: 5748
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis the pull request number.