Filestore alertlog 4881 v6 #9254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When filestore keyword is triggered, the file is not yet stored, when the alert is generated, but only marked for storing. Ticket: 4881
|
Information: QA ran without warnings. Pipeline 15325 |
| @@ -166,8 +166,12 @@ static void OutputFilestoreFinalizeFiles(ThreadVars *tv, const OutputFilestoreLo | |||
| ff->file_store_id) == (int)sizeof(js_metadata_filename)) { | |||
| WARN_ONCE(WOT_SNPRINTF, "Failed to write file info record. Output filename truncated."); | |||
| } else { | |||
| // Set temporarily flag that file is stored for logging. | |||
There was a problem hiding this comment.
can we get rid of this hack?
There was a problem hiding this comment.
Looks like unneeded thanks to `OUTPUT_FILEDATA_FLAG_CLOSE guarding the call on OutputFilestoreFinalizeFiles
victorjulien
requested changes
Jul 20, 2023
|
Replaced by #9266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4881
Describe changes:
storingin alert when it is planned to be stored...OISF/suricata-verify#1146
Rebase #9146 after Suricata7 release