Src div0 5920 v4 #9253
Closed
Src div0 5920 v4 #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -152,12 +152,18 @@ static void DPDKFreeMbufArray(struct rte_mbuf **mbuf_array, uint16_t mbuf_cnt, u | |||
| static uint64_t CyclesToMicroseconds(const uint64_t cycles) | |||
| { | |||
| const uint64_t ticks_per_us = rte_get_tsc_hz() / 1000000; | |||
| if (ticks_per_us == 0) { | |||
There was a problem hiding this comment.
@lukashino is this necessary? Or can rte_get_tsc_hz return < 1000000?
There was a problem hiding this comment.
Seems to be possible only when:
- the CPU would have a clock rate less than 100MHz
- the CPU would not be well supported by DPDK and some register would return 0/random number instead ticks per second
So, assuming every CPU has a clock rate of at least 800MHz, and we will not care about unsupported CPUs then it should be fine even without the check.
There was a problem hiding this comment.
ok thanks, I feel it's probably safer to keep the check
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 15326 |
victorjulien
approved these changes
Jul 25, 2023
Merged
|
Merged in #9288, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5920
Describe changes:
Modifies #9150 with rebase now that Suricata 7 is released and this is targeted for 7.0.1