-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci rustfmt v1 #9044
Ci rustfmt v1 #9044
Conversation
b9390b6
to
a574ec2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9044 +/- ##
==========================================
+ Coverage 82.24% 82.29% +0.05%
==========================================
Files 969 969
Lines 273655 273654 -1
==========================================
+ Hits 225055 225208 +153
+ Misses 48600 48446 -154
Flags with carried forward coverage won't be shown. Click here to find out more. |
Files formatted need to remain formatted
a574ec2
to
ec92a65
Compare
Information: QA ran without warnings. Pipeline 14755 |
@@ -0,0 +1,10 @@ | |||
r=0 | |||
cat qa/rustfmt.txt | while read i; do | |||
rustfmt $i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just call cargo fmt
then check each file.
@@ -0,0 +1,57 @@ | |||
rust/derive/src/applayerframetype.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe build this list within the context of the rust/
directory, as in where its valid to run cargo fmt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. While I'd rather just format master
and master-6.0.x
in one go at the same time, this is probably more realistic approach to get to whats expected of Rust projects today.
replaced by #9072 |
Link to redmine ticket:
None : QA
Describe changes: