-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust unused v5 #8976
Rust unused v5 #8976
Conversation
And detect.h does no longer depend on app-layer-events.h
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8976 +/- ##
==========================================
+ Coverage 82.42% 82.44% +0.02%
==========================================
Files 969 969
Lines 273476 273367 -109
==========================================
- Hits 225410 225382 -28
+ Misses 48066 47985 -81
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 14288 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pgsql changes still looking good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm OK with a rather aggressive purge of unused code. As we do 8, where lib stuff may be more of Suri, along with tightening down of Lua, unused functions may become more of the norm, yet should still have test cases. Just something to think about as we make this move more to a platform/framework for others.
Merged in #9001, thanks! |
@jasonish Should I also remove
|
Keep |
Link to redmine ticket:
None, generic cleaning
Describe changes:
Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /'
then see rust warnings when compilingThere is more to it :
APP_LAYER_PARSER_NO_INSPECTION_PAYLOAD
and like should only be defined on the rust sidepad
in DCERPCState) Coming in a next PRFollows #8880 with needed rebase