Alert queue optimizations - v2 #7290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial work to bring the alert queue processing to DetectEngineThreadCtx. Task OISF#4943
Sort the PacketAlert queue that will be passed to the Packet handling functions, so there's less work to be done with it from there. Task OISF#4943
Do all alert queue processing before actually appending the PacketAlerts to the Packet's alert queue. Task OISF#4943
Since we now only copy the PacketAlerts to the Packet's queue after processing them, we no longer do packet alert appending from detect-engine-alert, nor do we remove PacketAlerts from the queue (if they're discarded by overflow or thresholding, they're not copied to the final alert queue). Task OISF#4943
The maximum of possible alerts triggered by a unique packet was hardcoded to 15. With usage of 'noalert' rules, that limit could be reached somewhat easily. Make that configurable via suricata.yaml. Conf Bug#4941 Task OISF#4207
Add a counter to our stats log with the total of alerts that have been discarded due to packet alert queue overflow. Task OISF#5179
|
From what I gather, the CI failures are not related to this patch... |
|
Information: ERROR: QA failed on tlpw1_files_sha256.
Pipeline 7151 |
|
Rebased in #7297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #7284
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4943
Describe changes:
PacketAlertFinalizetx_idinto considerationOnce this work gets approved, then we can see if more work needs to be done in #7212
suricata-verify-pr: 808
OISF/suricata-verify#808