-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quic ietf 4967 v8 #7130
Closed
Closed
Quic ietf 4967 v8 #7130
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8dbe67e
quic: rustfmt
catenacyber 6d6f589
quic: complete parsing of initial for non gquic
catenacyber 9c5f217
rdp: bump up tls-parser crate version
catenacyber 6feb585
quic: parse more frames
catenacyber 38c90ee
quic: use packet num length when decrypting
catenacyber a6f8a2b
quic: do not try to parse encrypted data
catenacyber 2d77782
quic: decrypt in its own function
catenacyber 5babeaa
quic: use sni from crypto frame with tls
catenacyber 556a131
quic: ja3 computation and logging and detection
catenacyber 2fcce92
quic: function split in 2 and other style improvements
catenacyber 48ed785
quic: move earlier the check against header.length
catenacyber 9e0d20b
quic: use Suricata's own quic_tls_extension_name
catenacyber 6bd8d80
quic: parse gquic version Q039
catenacyber 190d858
quic: check against right remaining buffer
catenacyber 71bc1fd
quic: detect ja3 from server with keyword quic.ja3s
catenacyber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often, if ever would we endup not adding anything to this vector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when
parse_tls_extensions
fails, that is on malformed messages...What are you thinking of ?