-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quic ietf 4967 v5 #7106
Closed
Closed
Quic ietf 4967 v5 #7106
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c02bc93
quic: rustfmt
catenacyber aa27887
quic: complete parsing of initial for non gquic
catenacyber 2f72a10
rdp: bump up tls-parser crate version
catenacyber 2183393
quic: parse more frames
catenacyber ed2d06f
quic: use packet num length when decrypting
catenacyber 2242df3
quic: do not try to parse encrypted data
catenacyber 0cb101b
quic: decrypt in its own function
catenacyber 11b8197
quic: use sni from crypto frame with tls
catenacyber 0c138f2
quic: ja3 computation and logging and detection
catenacyber 1ee7792
quic: function split in 2 and other style improvements
catenacyber 5c9692e
quic: move earlier the check against header.length
catenacyber 58ba02d
quic: use Suricata's own quic_tls_extension_name
catenacyber 28c2b44
quic: parse gquic version Q039
catenacyber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TLS/tcp we only have
ja3
for client hello iirc, for the server side there isja3s
. How is that here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used only one
ja3
.I do not understand why there should be a different naming.
The client ja3 has EllipticCurve and EllipticCurvePointFormat data while the server does not have them (as the server is not supposed to send such extensions) cf
quic_tls_ja3_client_extends
Does that answer your question ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least for tls ja3 is for clients, ja3s for servers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not our invention, just part of the official "standard" https://github.com/salesforce/ja3#ja3s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, you want two signature keywords
ja3
andja3s
instead of usingtoclient
ortoserver
? Or ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to it match how we do it for tls, unless there is a good reason not to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #7130
I find it a bit strange as a code duplication, but I do not think this reason is good enough