lua: Fix SCRule functions for match scripts v2.1 #6568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save Signature structure to lua register so SCRule functions can work in match scripts, where no PacketAlert is present Resolves Feature OISF#2450
jufajardini
reviewed
Nov 3, 2021
| lua_pushstring (luastate, pa->s->class_msg); | ||
| lua_pushnumber (luastate, pa->s->prio); | ||
| lua_pushstring(luastate, s->class_msg); | ||
| lua_pushnumber(luastate, s->prio); |
There was a problem hiding this comment.
I think it should be lua_pushinteger here, to prevent it from being considered a float in newer Lua versions...
|
One thing that I only learned recently: it is necessary to remove the |
benajmin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6568 +/- ##
==========================================
+ Coverage 77.05% 77.08% +0.02%
==========================================
Files 613 613
Lines 186733 186692 -41
==========================================
+ Hits 143890 143909 +19
+ Misses 42843 42783 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 tasks
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 22, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 24, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 28, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 28, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Nov 29, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Dec 14, 2023
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Dec 14, 2023
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Dec 14, 2023
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Dec 14, 2023
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jan 2, 2024
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jan 2, 2024
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jan 4, 2024
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: #2450
Describe changes:
suricata-verify-pr: 577