-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: Fix SCRule functions for match scripts v2.1 #6568
Conversation
Save Signature structure to lua register so SCRule functions can work in match scripts, where no PacketAlert is present Resolves Feature OISF#2450
lua_pushstring (luastate, pa->s->class_msg); | ||
lua_pushnumber (luastate, pa->s->prio); | ||
lua_pushstring(luastate, s->class_msg); | ||
lua_pushnumber(luastate, s->prio); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be lua_pushinteger
here, to prevent it from being considered a float in newer Lua versions...
One thing that I only learned recently: it is necessary to remove the |
Codecov Report
@@ Coverage Diff @@
## master #6568 +/- ##
==========================================
+ Coverage 77.05% 77.08% +0.02%
==========================================
Files 613 613
Lines 186733 186692 -41
==========================================
+ Hits 143890 143909 +19
+ Misses 42843 42783 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
If a commit introduces code that changes Suricata behavior, the related documentation changes should go in a separate commit, but refer to the same ticket number. This reduces the chances of said changes being lost if there are backports while still keeping the backporting process a bit less bulky, for each commit. Related to Task OISF#6568
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: #2450
Describe changes:
suricata-verify-pr: 577