Http2 master6 v1 #6448
Closed
Http2 master6 v1 #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP1 uses Host, but HTTP2 uses rather :authority cf HPACK (cherry picked from commit 75f75e1)
(cherry picked from commit 547e9f4)
(cherry picked from commit 9b9f909)
As well as http.header.raw (cherry picked from commit 0b0649d)
so as not to forget continuation and push promise when iterating over headers (cherry picked from commit e3ff0e7)
For detection, as is done with HTTP1 (cherry picked from commit 48ed874)
(cherry picked from commit 596a4a9)
so that borrow check gets happy (cherry picked from commit 56fae07)
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
|
|
Are there SV tests that need to be adjusted to actually execute the backported code? |
|
WARNING:
Pipeline 4457 |
|
Maybe these were merged after this PR though. |
Merged
Indeed, they were merged in between... Replaced by #6453 |
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Nov 8, 2023
open-cmi
pushed a commit
to open-cmi/suricata
that referenced
this pull request
Nov 8, 2023
open-cmi
pushed a commit
to open-cmi/suricata
that referenced
this pull request
Nov 8, 2023
open-cmi
pushed a commit
to open-cmi/suricata
that referenced
this pull request
Nov 8, 2023
open-cmi
pushed a commit
to open-cmi/suricata
that referenced
this pull request
Nov 9, 2023
open-cmi
pushed a commit
to open-cmi/suricata
that referenced
this pull request
Nov 14, 2023
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4067
Describe changes: