-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devguide/transactions: add template examples #6241
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extending/applayer/transactions: third draft - typo fix - add definition of `flow` as found in inliniac's blog - strike off parenthesis text about per-flow state that didn't make much sense - doc/devguide: add transactions.rst - doc/devguide/extending/app-layer/index.rst: add transactions.rst
Add explanation about how transaction state is used for rule matching
Grammar refinement. Add examples of simple protocols. Refine some statements. Nit: fix markup.
add sequence diagrams as pngs generated by mscgen via a script Add image description to Sequence Diagrams Change table of contents be built with markup tell git to ignore *.png files
mscgen is used for generating Sequence Diagrams images. Let's make sure it's present before generating devguide docs.
Codecov Report
@@ Coverage Diff @@
## master #6241 +/- ##
==========================================
- Coverage 76.95% 76.86% -0.09%
==========================================
Files 611 611
Lines 186232 186232
==========================================
- Hits 143306 143152 -154
- Misses 42926 43080 +154
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Followed by: #6245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions documentation - v8
Describe changes:
(waiting for final approval to figure out the squashing process... If that's not ideal, I can fix that now.)
Link to Redmine issue: https://redmine.openinfosecfoundation.org/issues/4396
Previous PR: #6233