decode/vntag: Add decoder for 802.1Qbh #6083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6083 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 612 613 +1
Lines 187684 187727 +43
=======================================
+ Hits 144530 144565 +35
- Misses 43154 43162 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
requested changes
Apr 26, 2021
| @@ -1289,6 +1292,9 @@ static inline bool DecodeNetworkLayer(ThreadVars *tv, DecodeThreadVars *dtv, | |||
| DecodeEthernet(tv, dtv, p, data, len); | |||
| } | |||
| break; | |||
| case ETHERNET_TYPE_VNTAG: | |||
There was a problem hiding this comment.
wonder why codecov claims no coverage here
|
Continued in #6085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6081
This PR adds support for decoding VNTAG packets (https://www.ieee802.org/1/files/public/docs2009/new-pelissier-vntag-seminar-0508.pdf)
Describe changes:
suricata-verify-pr: 489
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: