-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decode/vntag: Add decoder for 802.1Qbh #6083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6083 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 612 613 +1
Lines 187684 187727 +43
=======================================
+ Hits 144530 144565 +35
- Misses 43154 43162 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some minor changes requested
@@ -1289,6 +1292,9 @@ static inline bool DecodeNetworkLayer(ThreadVars *tv, DecodeThreadVars *dtv, | |||
DecodeEthernet(tv, dtv, p, data, len); | |||
} | |||
break; | |||
case ETHERNET_TYPE_VNTAG: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder why codecov claims no coverage here
Continued in #6085 |
Continuation of #6081
This PR adds support for decoding VNTAG packets (https://www.ieee802.org/1/files/public/docs2009/new-pelissier-vntag-seminar-0508.pdf)
Describe changes:
suricata-verify-pr: 489
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: