Next/20210419/v4 #6070
Closed
Next/20210419/v4 #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate call to LogFileEnsureExists in the generic eve thread init function.
Reset the buffer here so each caller doesn't need to do it.
- mqtt - dnp3 - smtp - ike - dns - alert - tls - anomaly - drop - file - http - http2 - templates - dhcp The idea is to factor out the commom code for setting up the output file objects, which is repetitive, and often done wrong when it comes to threading.
All callers of OutputJsonBuilderBuffer are now calling it using fields from an OutputJsonThreadCtx, so just pass a pointer to the thread context now.
Lately, some of the TLS data was misdetected as DCERPC/TCP because of the pattern |05 00|. Add more checks in DCERPC probe function to ensure that it is in fact DCERPC/TCP.
This commit improves support for large address variables. Without this commit, address size was fixed at 8196 or less. This commit permits larger sized address variables.
Merged
Codecov Report
@@ Coverage Diff @@
## master #6070 +/- ##
==========================================
+ Coverage 76.94% 77.02% +0.07%
==========================================
Files 612 612
Lines 187760 187682 -78
==========================================
+ Hits 144469 144557 +88
+ Misses 43291 43125 -166
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Replaced by #6071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6060 #5508 #5808
dcerpc proto detect fix