Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/setup-app-layer: fix rust generation - v1 #5457

Closed
wants to merge 1 commit into from
Closed

scripts/setup-app-layer: fix rust generation - v1 #5457

wants to merge 1 commit into from

Conversation

jasonish
Copy link
Member

Fix Rust app-layer generation. Main parser file was being named
gopher.rs instead of the name of the protocol.

@jasonish
scripts/setup-app-layer: fix rust generation
ae65893 
Fix Rust app-layer generation. Main parser file was being named
gopher.rs instead of the name of the protocol.
@jasonish jasonish requested a review from a team as a code owner September 30, 2020 17:20
@victorjulien victorjulien mentioned this pull request Oct 5, 2020
Merged
@victorjulien
Copy link
Member

Merged in #5464, thanks!

@jasonish jasonish deleted the template-rust-fixup/v1 branch July 1, 2021 17:15
jufajardini added a commit to jufajardini/suricata that referenced this pull request Jul 25, 2022
@jufajardini
detect/engine: init alert queue counters on reload
93c2c97 
alert_queue_overflow and alerts_suppressed were not being
reinitialized when there was a reload of Suricata rules, leading to
non-valid stats counters if that happened.

Bug OISF#5457
@jufajardini jufajardini mentioned this pull request Jul 26, 2022
Merged
jufajardini added a commit to jufajardini/suricata that referenced this pull request Jul 26, 2022
@jufajardini
detect/engine: init alert queue counters on reload
b629e42 
alert_queue_overflow and alerts_suppressed were not being
reinitialized when there was a reload of Suricata rules, leading to
non-valid stats counters if that happened.

Bug OISF#5457

(cherry picked from commit 93c2c97)
@jufajardini jufajardini mentioned this pull request Jul 26, 2022
Closed
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jul 29, 2022
@jufajardini @victorjulien
detect/engine: init alert queue counters on reload
41967bf 
alert_queue_overflow and alerts_suppressed were not being
reinitialized when there was a reload of Suricata rules, leading to
non-valid stats counters if that happened.

Bug OISF#5457

(cherry picked from commit 93c2c97)
benignbala pushed a commit to benignbala/suricata that referenced this pull request Nov 12, 2022
@jufajardini @benignbala
detect/engine: init alert queue counters on reload
1487d25 
alert_queue_overflow and alerts_suppressed were not being
reinitialized when there was a reload of Suricata rules, leading to
non-valid stats counters if that happened.

Bug OISF#5457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucovsky jlucovsky jlucovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonish @victorjulien @jlucovsky