Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Napatech bypass v1.07 #4472

Closed
wants to merge 2 commits into from
Closed

Conversation

pjyoung1
Copy link
Contributor

@pjyoung1 pjyoung1 commented Jan 6, 2020

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2818

Describe changes:

Added hardware based bypass support on Napatech SmartNICs
Added support for inline processing using Napatech SmartNICs

This PR Addresses issues identified in the review of PR 4368
This reflects changes since PR Napatech bypass v1.04

Napatech hardware bypass support enables Suricata to utilize
capabilities of Napatech SmartNICs to selectively bypass flow-based
traffic.
Napatech hardware bypass support enables Suricata to utilize
capabilities of Napatech SmartNICs to selectively bypass flow-based
traffic.
@pjyoung1 pjyoung1 requested review from norg and a team as code owners January 6, 2020 19:18
Copy link
Contributor

@jlucovsky jlucovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ....

Some nits in comments and related.

src/runmode-napatech.c Show resolved Hide resolved
src/source-napatech.c Show resolved Hide resolved
src/source-napatech.c Show resolved Hide resolved
src/source-napatech.c Show resolved Hide resolved
src/source-napatech.c Show resolved Hide resolved
src/util-napatech.c Show resolved Hide resolved
src/util-napatech.c Show resolved Hide resolved
src/util-napatech.c Show resolved Hide resolved
src/util-napatech.c Show resolved Hide resolved
src/util-napatech.c Show resolved Hide resolved
@pjyoung1 pjyoung1 mentioned this pull request Jan 9, 2020
3 tasks
@pjyoung1
Copy link
Contributor Author

pjyoung1 commented Jan 9, 2020

Addressed review comments in Napatech_bypass_v1.09

@pjyoung1 pjyoung1 closed this Jan 9, 2020
@pjyoung1 pjyoung1 mentioned this pull request Jan 10, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants