Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tls store v1.4 #33

Closed
wants to merge 11 commits into from
Closed

Tls store v1.4 #33

wants to merge 11 commits into from

Conversation

regit
Copy link
Contributor

@regit regit commented Aug 23, 2012

Yet Another Try.

Popof and others added 11 commits August 23, 2012 16:03
@Popof @regit
tls: adding TLS Log support
efdf96c 
Creation of the log-tlslog file in order to log tls message.
Need to add some information into suricata.yaml to work.

  - tls-log:
      enabled: yes	# Log TLS connections.
      filename: tls.log # File to store TLS logs.
@Popof @regit
tls: adding cryptographic functions.
9071bcf 
Adding util-crypt containing cryptographic functions as SHA1 and Base64.
@regit
tls: add NSS version for SHA1 computing function.
afbf82c
@Popof @regit
tls: adding fingerprint calculation.
5e545e4 
Adding a pointer in ssl_state struct and compute fingerprint during
certificate decoding.
@Popof @regit
tls: adding fingerprint to TLS Log information.
79ea794 
Improve TLS logging by adding the certificate fingerprint to TLS Log file.
Add the extending option to the tls-log entry in suricata.yaml.
@Popof @regit
tls: adding support for fingerprint rule matching.
a12e481 
Add the support for tls.fingerprint keyword in rules.
@Popof @regit
tls: adding store option for TLS
bffc946 
This patch adds a TLS store option to save certificate in PEM format.
Each time the store action is met, a file and a metafile are created.

Reworked-by: Eric Leblond <eric@regit.org>
@regit
tls: keep pointers to all certificates in chain
917dcc3 
When multiple certificates forming a chain are sent. A pointer to
the start of each certificate is kept. This will allow treatment
on certificates chains.
@regit
tls: store all the certificates chain in the written PEM file.
0a4d841 
When using the tls.store command, a dump of all certificates in
the chain is now done on the disk.
@regit
detect-tls: various indent fixes.
f0b243a 
And delete a useless FIXME.
@regit
tls: suppress always true condition.
f425bf5
@inliniac
Copy link
Contributor

Building with nss/nspr fails: ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --enable-debug --enable-unittests --disable-gccmarch-native --enable-nfqueue --with-libnss-includes=/usr/include/nss/ --with-libnspr-includes=/usr/include/nspr/

gcc -DHAVE_CONFIG_H -I. -I.. -I../libhtp -I/usr/include/nspr/ -I/usr/include/nss/ -g -O2 -Wextra -Wall -fno-strict-aliasing -fno-tree-pre -Wno-unused-parameter -std=gnu99 -DUNITTESTS -DDEBUG -DNFQ -DHAVE_LIBNET11 -D_BSD_SOURCE -D__BSD_SOURCE -D__FAVOR_BSD -DHAVE_NET_ETHERNET_H -I/usr/include -DLIBPCAP_VERSION_MAJOR=1 -DHAVE_PCAP_SET_BUFF -DHAVE_LIBCAP_NG -DREVISION="f425bf5" -MT util-crypt.o -MD -MP -MF .deps/util-crypt.Tpo -c -o util-crypt.o util-crypt.c
util-crypt.c: In function ‘ComputeSHA1’:
util-crypt.c:240:5: error: unknown type name ‘HASHContext’
util-crypt.c:240:5: warning: implicit declaration of function ‘HASH_Create’ [-Wimplicit-function-declaration]
util-crypt.c:240:41: error: ‘HASH_AlgSHA1’ undeclared (first use in this function)
util-crypt.c:240:41: note: each undeclared identifier is reported only once for each function it appears in
util-crypt.c:248:9: warning: implicit declaration of function ‘HASH_Destroy’ [-Wimplicit-function-declaration]
util-crypt.c:251:5: warning: implicit declaration of function ‘HASH_Begin’ [-Wimplicit-function-declaration]
util-crypt.c:252:5: warning: implicit declaration of function ‘HASH_Update’ [-Wimplicit-function-declaration]
util-crypt.c:252:18: error: ‘md’ undeclared (first use in this function)
util-crypt.c:253:5: warning: implicit declaration of function ‘HASH_End’ [-Wimplicit-function-declaration]
util-crypt.c: In function ‘Base64Encode’:
util-crypt.c:270:15: error: ‘SC_BASE64_INVALID_ARG’ undeclared (first use in this function)
util-crypt.c:276:14: error: ‘SC_BASE64_OVERFLOW’ undeclared (first use in this function)
util-crypt.c:301:11: error: ‘SC_BASE64_OK’ undeclared (first use in this function)
util-crypt.c:302:1: warning: control reaches end of non-void function [-Wreturn-type]
make[3]: *** [util-crypt.o] Error 1

@inliniac inliniac closed this Aug 24, 2012
@nowaits nowaits mentioned this pull request May 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regit @inliniac @Popof