misc: fix build of rules profiling #12039
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch a0fc2b8 has removed the declaration of functions used when building with ruleset profiling only (without --enable-profiling). This is causing a build failure. This patch moves the declaration to the rules profiling section to be sure it is always there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12039 +/- ##
==========================================
- Coverage 83.42% 83.41% -0.01%
==========================================
Files 910 910
Lines 257642 257642
==========================================
- Hits 214934 214914 -20
- Misses 42708 42728 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 23186 |
|
Thanks Eric, I think this shows missing coverage in our github ci workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch a0fc2b8 has removed the declaration of functions used when building with ruleset profiling only (without --enable-profiling). This is causing a build failure.
This patch moves the declaration to the rules profiling section to be sure it is always there.
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7345
Describe changes: