app-layer events: consistently use uint8_t/u8 as the event id #12010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust was using i8 as the return type, while C uses int. As of Rust 1.82, the return value is turned to garbage over the FFI boundary. Ticket: OISF#7338
Note: For event IDs in the enum that are larger than a uint8_t, -1 will be returned instead of -4. -4 has special meaning during signature parsin that means requirements were not met. -4 has no special handling prior to requirements, or the meaning has been lost.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12010 +/- ##
=======================================
Coverage 83.22% 83.22%
=======================================
Files 910 910
Lines 258136 258141 +5
=======================================
+ Hits 214831 214847 +16
+ Misses 43305 43294 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23164 |
|
Do we have a sense of having u8 is big enough? |
Appears we get into the 30s for a few app-layers, but I think that's as high as we get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #12009 to be consistent about the data type used for event IDs. #12009 shows us how important this is especially when something passes an ffi boundary.