-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpdk/hw_offload: add support for vlan stripping - v3 #12008
Conversation
Utilize DPDK API for hardware vlan stripping if supported by NIC. Ticket: 7330
NOTE: This PR may contain new authors. |
@@ -616,6 +618,13 @@ static int ConfigSetChecksumOffload(DPDKIfaceConfig *iconf, int entry_bool) | |||
SCReturnInt(0); | |||
} | |||
|
|||
static int ConfigSetVlanStrip(DPDKIfaceConfig *iconf, int entry_bool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you didn't change the function to void
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I noticed it only at the tests, my bad. I will make one more iteration of PR.
@@ -807,6 +816,13 @@ static int ConfigLoad(DPDKIfaceConfig *iconf, const char *iface) | |||
if (retval < 0) | |||
SCReturnInt(retval); | |||
|
|||
retval = ConfGetChildValueBoolWithDefault( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the function is void then retval should not be assigned. Then you don't need to check for the return code of retval (if-statement at L823)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left inline comments, we are moving forward! 🚅
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12008 +/- ##
==========================================
- Coverage 83.22% 82.34% -0.89%
==========================================
Files 910 904 -6
Lines 258136 256357 -1779
==========================================
- Hits 214831 211093 -3738
- Misses 43305 45264 +1959
Flags with carried forward coverage won't be shown. Click here to find out more. |
Continues in #12014 |
Utilize DPDK API for hardware vlan stripping if supported by NIC.
Ticket: 7330
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/issues/7330
Previous PR #11997
Describe changes:
v3
v2
v1