dpdk/hw_offload: add support for vlan stripping - v3 #12008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize DPDK API for hardware vlan stripping if supported by NIC. Ticket: 7330
|
NOTE: This PR may contain new authors. |
3 tasks
lukashino
reviewed
Oct 22, 2024
| @@ -616,6 +618,13 @@ static int ConfigSetChecksumOffload(DPDKIfaceConfig *iconf, int entry_bool) | |||
| SCReturnInt(0); | |||
| } | |||
|
|
|||
| static int ConfigSetVlanStrip(DPDKIfaceConfig *iconf, int entry_bool) | |||
There was a problem hiding this comment.
you didn't change the function to void
There was a problem hiding this comment.
Yes, I noticed it only at the tests, my bad. I will make one more iteration of PR.
lukashino
reviewed
Oct 22, 2024
| @@ -807,6 +816,13 @@ static int ConfigLoad(DPDKIfaceConfig *iconf, const char *iface) | |||
| if (retval < 0) | |||
| SCReturnInt(retval); | |||
|
|
|||
| retval = ConfGetChildValueBoolWithDefault( | |||
There was a problem hiding this comment.
if the function is void then retval should not be assigned. Then you don't need to check for the return code of retval (if-statement at L823)
lukashino
requested changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12008 +/- ##
==========================================
- Coverage 83.22% 82.34% -0.89%
==========================================
Files 910 904 -6
Lines 258136 256357 -1779
==========================================
- Hits 214831 211093 -3738
- Misses 43305 45264 +1959
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 tasks
|
Continues in #12014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize DPDK API for hardware vlan stripping if supported by NIC.
Ticket: 7330
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/issues/7330
Previous PR #11997
Describe changes:
v3
v2
v1