Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function declarations-v3 #11993

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 19, 2024

Ticket: #7297

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297

Describe changes:
-Remove duplicate function declarations fro header files
-I used this to find the duplicates:

cat src/*.h | grep -E "^[a-zA-Z_].*\(.*\);" | sort | uniq -c | awk '$1 == 2'
  • Then to find specific files where the funtions are, I used:
grep -Rn "DetectEngineBufferTypeGetById" src/*.h

Previous pr #11990

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nancyenos Nice work! Looking good from the first look. :)
Minor change requested inline.
Also, I think Juliana's first point in this comment on your last PR still needs attention: #11990 (review)

@@ -1594,8 +1594,6 @@ void *DetectGetInnerTx(void *tx_ptr, AppProto alproto, AppProto engine_alproto,
void RuleMatchCandidateTxArrayInit(DetectEngineThreadCtx *det_ctx, uint32_t size);
void RuleMatchCandidateTxArrayFree(DetectEngineThreadCtx *det_ctx);

void AlertQueueInit(DetectEngineThreadCtx *det_ctx);
void AlertQueueFree(DetectEngineThreadCtx *det_ctx);
void AlertQueueAppend(DetectEngineThreadCtx *det_ctx, const Signature *s, Packet *p, uint64_t tx_id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fn is also duplicated.

@Nancyenos
Copy link
Contributor Author

Hey @inashivb , please can you kindly explain what am doing wrong with the commit?
I think am not getting it
Thank you

@inashivb
Copy link
Member

Hey @inashivb , please can you kindly explain what am doing wrong with the commit? I think am not getting it Thank you

Just add a prefix misc: to the subject like c9e4524b3c71d0177 😉

@Nancyenos
Copy link
Contributor Author

Hey @inashivb , please can you kindly explain what am doing wrong with the commit? I think am not getting it Thank you

Just add a prefix misc: to the subject like c9e4524b3c71d0177 😉

ooh. Thank you/Totally missed it 😃

@Nancyenos
Copy link
Contributor Author

work continued in #11998

@Nancyenos Nancyenos closed this Oct 21, 2024
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants