Cppcheck/v2 #11967
Closed
Cppcheck/v2 #11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more compact time format.
It tripped up cppcheck:
src/util-time.h:124:35: error: syntax error [syntaxError]
return !timercmp(first, second, >);
Clang 19:
util-hash-string.c:41:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
41 | int len1 = strlen((char *)data1);
| ~~~~ ^~~~~~~~~~~~~~~~~~~~~
util-hash-string.c:42:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
42 | int len2 = strlen((char *)data2);
| ~~~~ ^~~~~~~~~~~~~~~~~~~~~
2 errors generated.
Issue warning if thread sleeps for a long time.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11967 +/- ##
==========================================
+ Coverage 82.76% 82.78% +0.01%
==========================================
Files 910 910
Lines 249014 249015 +1
==========================================
+ Hits 206105 206149 +44
+ Misses 42909 42866 -43
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23109 |
jufajardini
reviewed
Oct 23, 2024
| struct timeval systs; | ||
| gettimeofday(&systs, NULL); | ||
| t->sys_sec_stamp = (uint32_t)systs.tv_sec; | ||
| struct timeval tv; |
There was a problem hiding this comment.
I see that in same situations we're still using timeval. What's the criteria, now? Is timeval only for local variables, and for setting or initializing an SCTime_t?
There was a problem hiding this comment.
we still need it for gettimeofday
| SCMutexUnlock(&thread_store_lock); | ||
| } | ||
|
|
||
| bool TmThreadsTimeSubsysIsReady(void) | ||
| { | ||
| static SCTime_t nullts; |
There was a problem hiding this comment.
SCTIME_INITIALIZER not needed in this case?
Closed
|
replaced by #12027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cppcheck 2.14 fixes plus a few misc improvements.
Replaces #11946, implementing review comments.