Detect validate callbacks 5634 v4 #11963
Open
+97
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5634 Allows to share the same validator functions when only the buffer id is changing like for urilen
Ticket: 5634
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11963 +/- ##
==========================================
+ Coverage 82.76% 82.78% +0.01%
==========================================
Files 910 910
Lines 249014 248910 -104
==========================================
- Hits 206105 206055 -50
+ Misses 42909 42855 -54
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5634
Describe changes:
#11902 with review taken into account :
ValidateCallbackis not specialized, but extended to have the buffer id, so that keywords can share the same validator code when this buffer id is the only thing changingThis was done on the way to convert quic keywords to rust like #11575
With this PR, it should be easy to add a wrapper for rust for this ValidateCallback stuff