Tcp mss keyword 6355 v10 #10841
Merged
Tcp mss keyword 6355 v10 #10841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As will be needed for tcp.mss
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10841 +/- ##
==========================================
+ Coverage 82.83% 82.87% +0.03%
==========================================
Files 913 914 +1
Lines 246847 246887 +40
==========================================
+ Hits 204474 204604 +130
+ Misses 42373 42283 -90
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20060 |
victorjulien
approved these changes
Apr 15, 2024
Merged
|
Merged in #10852, thanks! |
|
Thanks @0xEniola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6355
Describe changes:
SV_BRANCH=OISF/suricata-verify#1759
#10826 with even better names with SC prefix, and commit split in 2