detect/analyzer: add more details for tcp_mss #10824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more details to the tcp.mss keyword engine analysis output Issue: OISF#6355
This was referenced Apr 12, 2024
| case DETECT_TCPMSS: { | ||
| const DetectU16Data *cd = (const DetectU16Data *)smd->ctx; | ||
| jb_open_object(js, "tcp_mss"); | ||
| rs_detect_u16_dump(js, cd); |
There was a problem hiding this comment.
not a fan of the dump naming, can we just call it to_json or to_jb or similar?
|
Replaced by #10826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6355
Describe changes:
SV_BRANCH=OISF/suricata-verify#1759
#9778 with output changed as asked by Jason, and moving to generic rust for uint stringing, also handling the new cases since (rust checks for switch completeness)