iprep: test reputation & category file newline handling #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit e7c0f0ad9 src: remove multiple uses of atoi caused a regression in parsing of ip-rep reputation config files. Previously, due to the use of atoi() in parsing ip-rep values, when the line was split by SRepSplitLine the \r at following the reputation score was ignored. Bug: #6243
3 tasks
3 tasks
Closed
|
Merged in #1372, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 'e7c0f0ad9 src: remove multiple uses of atoi' caused a regression in parsing of ip-rep reputation config files.
Previously, parsing ip-rep values in reputation config files succeeded for CR and CR+LF due to the use of atoi() in parsing ip-rep values, when the line was split by SRepSplitLine the \r at following the reputation score was ignored.
Bug: #6243
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6243