Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/verdict: remove min check for version 7 - v1 #1336

Closed
wants to merge 1 commit into from
Closed

tests/verdict: remove min check for version 7 - v1 #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 1 addition & 40 deletions tests/bug-5464-verdict-01/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,7 @@ args:
pcap: ../detect-app-layer-protocol-02/input.pcap

checks:
# checks for Suricata 6
- filter:
lt-version: 7
count: 1
match:
pcap_cnt: 1
event_type: drop
alert.action: blocked
alert.signature_id: 1
- filter:
lt-version: 7
count: 1
match:
pcap_cnt: 1
event_type: alert
alert.action: blocked
alert.signature_id: 1
- filter:
lt-version: 7
count: 1
match:
pcap_cnt: 1
event_type: alert
alert.action: blocked
alert.signature_id: 2

# checks for Suricata 7
- filter:
min-version: 7
count: 1
match:
event_type: alert
Expand All @@ -46,7 +18,6 @@ checks:
verdict.reject-target: to_server
verdict.reject: ["tcp-reset"]
- filter:
min-version: 7
count: 1
match:
event_type: alert
Expand All @@ -56,65 +27,55 @@ checks:
verdict.reject-target: to_server
verdict.reject: ["tcp-reset"]
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 1
verdict.action: drop
verdict.reject-target: to_server
verdict.reject-target: to_server
verdict.reject: ["tcp-reset"]
- filter:
min-version: 7
count: 0
match:
event_type: alert
alert.signature_id: 3
verdict.action: alert
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 5
verdict.action: drop
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 6
verdict.action: drop
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 7
verdict.action: drop
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 8
verdict.action: drop
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 9
verdict.action: drop
- filter:
min-version: 7
count: 1
match:
event_type: drop
pcap_cnt: 10
verdict.action: drop

# Checks valid for both
- filter:
count: 1
match:
Expand Down
3 changes: 0 additions & 3 deletions tests/bug-5464-verdict-02/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
requires:
min-version: 7

args:
- --simulate-ips

Expand Down
1 change: 0 additions & 1 deletion tests/bug-5464-verdict-03/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
requires:
min-version: 7
features:
- LIBNET1.1

Expand Down
3 changes: 0 additions & 3 deletions tests/bug-5464-verdict-04/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
requires:
min-version: 7

pcap: ../tls/tls-ja3s/input.pcap

args:
Expand Down
3 changes: 0 additions & 3 deletions tests/bug-5464-verdict-05/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
requires:
min-version: 7

args:
- -k none
- --runmode=single
Expand Down
1 change: 0 additions & 1 deletion tests/bug-5464-verdict-06/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
requires:
min-version: 7
features:
- LIBNET1.1

Expand Down
3 changes: 1 addition & 2 deletions tests/bug-5464-verdict-07/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
requires:
min-version: 7
features:
- LIBNET1.1

Expand All @@ -14,5 +13,5 @@ checks:
match:
event_type: alert
verdict.action: alert
verdict.reject-target: to_client
verdict.reject-target: to_client
verdict.reject: [icmp-prohib]
Loading