Fix cross product to compute Z direction in getImageData #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate code to correctly use this function.
|
Hey, thanks for the contribution! Good catch. |
JamesAPetts
reviewed
Oct 18, 2019
| ); | ||
| const crossProduct = colCosineVec.cross(rowCosineVec); | ||
|
|
||
| const crossProduct = new Vector3( |
There was a problem hiding this comment.
Could this just be:
const crossProduct = new Vector3(
rowCosines[0],
rowCosines[1],
rowCosines[2]
).cross(colCosineVec);
To reduce confusion on the initial definition?
There was a problem hiding this comment.
Yes of course, thanks! I updated the pull request as suggested.
|
🎉 This PR is included in version 0.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cross method from cornerstone-math modifies the calling object. Update code to correctly use this function.