Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower WhiteRabbit default memory allocation #260

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Lower WhiteRabbit default memory allocation #260

merged 2 commits into from
Aug 4, 2020

Conversation

MaximMoinat
Copy link
Collaborator

Fixes #220, Fixes #241

The memory allocation was increased for BigQuery integration, but causes issues on Windows systems.

@MaximMoinat MaximMoinat added the WhiteRabbit Issue concerning the creation of scan report label Jul 30, 2020
@MaximMoinat
Copy link
Collaborator Author

Also linking in issue #255

@MaximMoinat MaximMoinat requested a review from blootsvoets July 30, 2020 10:08
blootsvoets
blootsvoets approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just make sure to bump the version number to 0.10.2 (instead of -SNAPSHOT), and to merge back the hot fix to the dev branch as well.

@MaximMoinat MaximMoinat changed the base branch from master to develop August 4, 2020 15:24
@MaximMoinat MaximMoinat merged commit 56d58a9 into develop Aug 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the wr-memory branch August 4, 2020 15:24
@MaximMoinat MaximMoinat mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets approved these changes

Assignees
No one assigned
Labels
WhiteRabbit Issue concerning the creation of scan report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce Java VM memory allocation for WhiteRabbit WhiteRabbit v0.9.0 Unable to Launch
2 participants
@MaximMoinat @blootsvoets