CDM v6 fixes #210
Merged
CDM v6 fixes #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2020 16:22
|
@MaximMoinat wait, did you mean to have me do the MERGE? I reviewed and see you have added what is needed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix column definitions of the OMOP CDM v6 target model according to: https://github.com/OHDSI/CommonDataModel/blob/master/OMOP_CDM_v6_0.csv
The most important fix is the required status of the
dateanddatetimecolumns, which was still adhering to v5 conventions. With this PR, thedatetimeis required anddateis not as per v6 conventions.