Scan SAS files #195
Merged
Scan SAS files #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blootsvoets
reviewed
Nov 16, 2019
whiterabbit/src/main/java/org/ohdsi/whiteRabbit/WhiteRabbitMain.java
Outdated
Show resolved
Hide resolved
whiterabbit/src/main/java/org/ohdsi/whiteRabbit/scan/SourceDataScan.java
Outdated
Show resolved
Hide resolved
| @@ -26,7 +26,8 @@ | |||
| public class DbSettings { | |||
| public static int DATABASE = 1; | |||
| public static int CSVFILES = 2; | |||
|
|
|||
| public static int SASFILES = 3; | |||
There was a problem hiding this comment.
Would it make sense to make this an enum? Alternatively, you could distinguish on “database” vs “file” as source type, and for each source type be able to select a format (db: postgres; file: csv)
There was a problem hiding this comment.
Not implementing this atm, would affect a lot of parts of the code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Parso library (https://lifescience.opensource.epam.com/parso.html) to read sas7bdat files and write a scan report. Implementation is similar to how CSV files are scanned.
Note that this PR does not support writing fake data in the sas7bdat format. The Parso library does not seem to support writing to sas files and as it is a proprietary format, I think this might not be possible.
Also, as this implementation processes a sas file similar to csv; it scans values to derive data types. However, a sas file has associated properties like a database which we can use to read data type and length without reading the values.