-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept id hints #188
Merged
Merged
Concept id hints #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th concept_id in detailspanel
…lue counts attribute
MaximMoinat
force-pushed
the
concept-id-hints
branch
from
September 27, 2019 11:40
9e3673d
to
c300803
Compare
blootsvoets
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just some Java/style pointers.
rabbit-core/src/main/java/org/ohdsi/rabbitInAHat/dataModel/ConceptsMap.java
Outdated
Show resolved
Hide resolved
rabbit-core/src/main/java/org/ohdsi/rabbitInAHat/dataModel/ConceptsMap.java
Outdated
Show resolved
Hide resolved
rabbit-core/src/main/java/org/ohdsi/rabbitInAHat/dataModel/ConceptsMap.java
Outdated
Show resolved
Hide resolved
rabbitinahat/src/main/java/org/ohdsi/rabbitInAHat/DetailsPanel.java
Outdated
Show resolved
Hide resolved
rabbit-core/src/main/java/org/ohdsi/rabbitInAHat/dataModel/ConceptsMap.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display concept id hints when selecting target fields, e.g. the available gender concepts for the
gender_concept_id
and the type concepts. The concept_id hints are loaded from a separate csv file, which has to kept up to date with vocabulary releases.This PR introduces a
TargetFieldPanel
, to display the CDM field details including concept_id hints. This formats the values table specifically for concept id hints.https://github.com/thehyve/OHDSI-WhiteRabbit/blob/9e3673dbe8bc2a14def8ef17104d39d1e4f6455d/rabbitinahat/src/main/java/org/ohdsi/rabbitInAHat/DetailsPanel.java#L479-L499
Closes #163