Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept id hints #188

Merged
merged 12 commits into from
Sep 27, 2019
Merged

Concept id hints #188

merged 12 commits into from
Sep 27, 2019

Conversation

MaximMoinat
Copy link
Collaborator

Display concept id hints when selecting target fields, e.g. the available gender concepts for the gender_concept_id and the type concepts. The concept_id hints are loaded from a separate csv file, which has to kept up to date with vocabulary releases.

This PR introduces a TargetFieldPanel , to display the CDM field details including concept_id hints. This formats the values table specifically for concept id hints.
https://github.com/thehyve/OHDSI-WhiteRabbit/blob/9e3673dbe8bc2a14def8ef17104d39d1e4f6455d/rabbitinahat/src/main/java/org/ohdsi/rabbitInAHat/DetailsPanel.java#L479-L499

Closes #163

Copy link
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just some Java/style pointers.

@MaximMoinat MaximMoinat merged commit 82e6c8a into OHDSI:develop Sep 27, 2019
@MaximMoinat MaximMoinat deleted the concept-id-hints branch September 27, 2019 15:44
@MaximMoinat MaximMoinat mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants