Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time columns in measurement table #150

Closed
pavgra opened this issue Jan 15, 2018 · 1 comment
Closed

Time columns in measurement table #150

pavgra opened this issue Jan 15, 2018 · 1 comment
Assignees
@clairblacketer
Labels
Bug

Comments

@pavgra
Copy link

pavgra commented Jan 15, 2018

@clairblacketer,

I see that measurement table contains both measurement_time and measurement_datetime columns, whereas the first one is not mentioned in specification (OMOP_CDM_v5_3.pdf) and seems to be deprecated. Do I miss smth?

https://github.com/OHDSI/CommonDataModel/blob/master/PostgreSQL/OMOP%20CDM%20postgresql%20ddl.txt#L450

measurement_time              VARCHAR(10) NULL ,
measurement_datetime			    TIMESTAMP		NULL ,
@clairblacketer clairblacketer self-assigned this Jan 19, 2018
@clairblacketer clairblacketer mentioned this issue Jan 19, 2018
Closed
@clairblacketer
Copy link
Contributor

measurement_time was an addition in 5.0.1, I added it back in to 5.3 because it was removed from 5.2 and therefore not backwards compatible. I will fix the documentation to reflect this

clairblacketer added a commit that referenced this issue Feb 7, 2018
@clairblacketer
Closes #150
9431a2c
clairblacketer added a commit that referenced this issue Feb 7, 2018
@clairblacketer
Closes #150. Changed measurement_time to measurement_datetime.
dab7208
clairblacketer added a commit that referenced this issue Feb 7, 2018
@clairblacketer
Addresses #150, adding time back in to the measurement table for back…
2c952dc 
…wards compatibility
@clairblacketer clairblacketer mentioned this issue Feb 7, 2018
Merged
clairblacketer added a commit that referenced this issue Feb 8, 2018
@clairblacketer
Merge pull request #157 from OHDSI/cdm_V5.3.-issue-150
33294de 
Closes #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clairblacketer clairblacketer

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavgra @clairblacketer