Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted extra changes back #1699

Closed
wants to merge 3 commits into from
Closed

Reverted extra changes back #1699

wants to merge 3 commits into from

Conversation

aklochkova
Copy link
Contributor

Fixes #1338

this PR is only for fixing 'master' branch

@aklochkova aklochkova requested a review from pavgra April 23, 2019 17:29
pavgra
pavgra suggested changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@pavgra pavgra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why any of the changes except for cohortDefinition.expression = JSON.parse(cohortDefinition.expression); are required?

@aklochkova
Copy link
Contributor Author

@pavgra hi! because that code changes were my own initiative and they aren't relative to this task. and there is no code style convention, so i decided to revert all of them back.

@aklochkova aklochkova requested a review from pavgra April 24, 2019 07:41
@pavgra pavgra closed this Apr 25, 2019
@chrisknoll chrisknoll deleted the issue-1338-partly-reverted branch April 5, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavgra pavgra Awaiting requested review from pavgra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entities names should be unique
2 participants
@aklochkova @pavgra