Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohort Definition Inclusion Rule UI Enhancements #302

Closed
jhardin29 opened this issue Jan 6, 2017 · 1 comment
Closed

Cohort Definition Inclusion Rule UI Enhancements #302

jhardin29 opened this issue Jan 6, 2017 · 1 comment
Assignees
@chrisknoll
Labels
cohort enhancement
Milestone
V1.4.0

Comments

@jhardin29
Copy link

jhardin29 commented Jan 6, 2017 •
edited
Loading

Hi,

A few feature requests that would be nice to have in ATLAS would be:

  1. in the text view window the description fields from the inclusion rules could be captured
  2. if before a cohort is generated can there be a check to confirm that the inclusion rule titles are 255 chars or less and if they are not then highlight them so they can be shortened?
  3. can a feature be added to include more than 64 inclusion rules?

tagging @ericaVoss @fdefalco @anthonysena @chrisknoll
@chrisknoll chrisknoll changed the title a few feature requests Cohort Definition Inclusion Rule UI Enhancements Jan 6, 2017
@chrisknoll
Copy link
Collaborator

Hi, I can work on these. Except for item 3: in order to do the inclusion rule intersection report, we use a bitmap which is limited to a 64-bit integer. The work around is to collapse different inclusion rules in to a single AND .. AND... AND rule to keep the number of rules below 64.

@chrisknoll chrisknoll self-assigned this Jan 6, 2017
@chrisknoll chrisknoll added this to the V1.4.0 milestone Jan 7, 2017
chrisknoll added a commit that referenced this issue Jan 10, 2017
@chrisknoll
Cohort Definition Inclusion Rule UI Enhancments. Fixes #302
4848bac 
Fixed issue with auto-sizing content editable fields.
Limit title input box to 255 characters.
Show inclusion rule description as a sub heading of the inclusion rule list if description.length > 0.
fdefalco pushed a commit that referenced this issue Jan 17, 2017
@chrisknoll @fdefalco
Cohort Definition Inclusion Rule UI Enhancments. Fixes #302
e24aa4a 
Fixed issue with auto-sizing content editable fields.
Limit title input box to 255 characters.
Show inclusion rule description as a sub heading of the inclusion rule list if description.length > 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisknoll chrisknoll

Labels
cohort enhancement
Projects
None yet
Milestone
V1.4.0
Development

No branches or pull requests
3 participants
@chrisknoll @jhardin29 @anthonysena