Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance usability of Achilles Heel #209

Closed
t-abdul-basser opened this issue Aug 8, 2017 · 11 comments
Closed

Enhance usability of Achilles Heel #209

t-abdul-basser opened this issue Aug 8, 2017 · 11 comments
Assignees

Comments

@t-abdul-basser
Copy link
Contributor

Cleans up Achilles Heel including

  • enhance the text in the Achilles Heels error/warning/notifications for readability
  • add category description to each error/warning/notifications
  • adding sortability by n
  • Organization/developers involved in the implementation

Overlaps with @alondhe recent efforts.

@t-abdul-basser t-abdul-basser self-assigned this Aug 8, 2017
@t-abdul-basser t-abdul-basser added this to the v1.3.1 milestone Aug 8, 2017
@vojtechhuser
Copy link
Contributor

What do you mean by sortability by n ? (this is atlas item in my view.
Achilles simply must have a good table to capture it but display is in atlas.

@t-abdul-basser
Copy link
Contributor Author

Good catch. I meant sort by arbitrary column and yes that should go in Atlas.

@t-abdul-basser t-abdul-basser modified the milestones: v1.5.0, v1.6.0 May 8, 2018
@cukarthik
Copy link

In this refactoring, would it be possible to add the ability for a site to reorganize the Achilles message types? Based on how we populate our data, it would be nice to reclassify some ERRORS as NOTIFICATIONS. For example, we do not populate locations so do not want to have those messages tagged as an error.

@PRijnbeek
Copy link
Contributor

I very useful feature would be if the Achilles Heel report would have the option to download the rendered SQL that is behind that query. This would allow you to very easily find the problem instead of first dive into the code base to find the query and then have to render and translate to your own dialect.

@alondhe
Copy link
Collaborator

alondhe commented May 18, 2018

Hi @PRijnbeek - there is a sqlOnly option, also, the return value of the achilles or achillesHeel functions does include it

@PRijnbeek
Copy link
Contributor

PRijnbeek commented May 19, 2018 via email

@vojtechhuser
Copy link
Contributor

vojtechhuser commented May 21, 2018

@PRijnbeek ad your question about

This would allow you to very easily find the problem

please look into file called Rule Drill Down here: https://github.com/OHDSI/Achilles/blob/master/inst/csv/rule_drill_down.csv
(and scroll down to column code)

For non-umbrella rules, this allows to find exactly what you want. I developed this knowledge base with the goal to display it as a hyperlink in Atlas next to the heel message output. (for developer to "drill down"). Hence the name of the CSV fille. - rule-drill down.

@MaximMoinat
Copy link
Contributor

I was looking into the readability of Achilles Heel output as well. One thing I would really like to do, is sorting on the count. An example of how I now organise the Achilles Heel report:
image

The count as percentage of total row count would be even better.

@vojtechhuser
Copy link
Contributor

I do like the percentage option. My newest additions to Heel were using the percentage paradigm. See - for example - the newest unmapped data rules. And I am suggesting R as a way to compute it. Because simple things fit in memory and can be done simpler than translating it into 7 sql dialects.

@PRijnbeek
Copy link
Contributor

@vojtechhuser thanks, yes i had seen that before.

What i have done for our ETL is that i have a sql file with all the errors found in earlier sprints in our SQL dialect that will give me a list of all the patients the are in the count of that error so we can dive deeper.

The drilldown csv is now in T-SQL probably and needs translation with SQLRender.

I like to the idea to have a link or maybe even a button next to the error that will execute the query against the CDM and will show me the (top X) problematic records (with an export function).

This can be in the Achilles Heel report/sheet itself or maybe we can have a simple Shiny-App the can do this using R and all the nice tools we have there..

@t-abdul-basser t-abdul-basser modified the milestones: v1.6.0, v1.7.0 Oct 18, 2018
@alondhe
Copy link
Collaborator

alondhe commented Oct 23, 2018

The new Shiny app addresses these ideas, closing this ticket, but if there are ideas on how to improve the Shiny app, please feel free to open a new issue.

@alondhe alondhe closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants