-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance usability of Achilles Heel #209
Comments
What do you mean by sortability by n ? (this is atlas item in my view. |
Good catch. I meant sort by arbitrary column and yes that should go in Atlas. |
In this refactoring, would it be possible to add the ability for a site to reorganize the Achilles message types? Based on how we populate our data, it would be nice to reclassify some ERRORS as NOTIFICATIONS. For example, we do not populate locations so do not want to have those messages tagged as an error. |
I very useful feature would be if the Achilles Heel report would have the option to download the rendered SQL that is behind that query. This would allow you to very easily find the problem instead of first dive into the code base to find the query and then have to render and translate to your own dialect. |
Hi @PRijnbeek - there is a sqlOnly option, also, the return value of the achilles or achillesHeel functions does include it |
Thanks that helps a bit already.
From: Ajit Londhe <notifications@github.com>
Reply-To: OHDSI/Achilles <reply@reply.github.com>
Date: Friday, 18 May 2018 at 13:51
To: OHDSI/Achilles <Achilles@noreply.github.com>
Cc: Peter Rijnbeek <p.rijnbeek@erasmusmc.nl>, Mention <mention@noreply.github.com>
Subject: Re: [OHDSI/Achilles] Enhance usability of Achilles Heel (#209)
Hi @PRijnbeek<https://github.com/PRijnbeek> - there is a sqlOnly option, also, the return value of the achilles or achillesHeel functions does include it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#209 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG6oiSK0AdZoZYPVV6d9YWeUtyU6k-inks5tzrWxgaJpZM4OxZQA>.
|
@PRijnbeek ad your question about
please look into file called Rule Drill Down here: https://github.com/OHDSI/Achilles/blob/master/inst/csv/rule_drill_down.csv For non-umbrella rules, this allows to find exactly what you want. I developed this knowledge base with the goal to display it as a hyperlink in Atlas next to the heel message output. (for developer to "drill down"). Hence the name of the CSV fille. - rule-drill down. |
I do like the percentage option. My newest additions to Heel were using the percentage paradigm. See - for example - the newest unmapped data rules. And I am suggesting R as a way to compute it. Because simple things fit in memory and can be done simpler than translating it into 7 sql dialects. |
@vojtechhuser thanks, yes i had seen that before. What i have done for our ETL is that i have a sql file with all the errors found in earlier sprints in our SQL dialect that will give me a list of all the patients the are in the count of that error so we can dive deeper. The drilldown csv is now in T-SQL probably and needs translation with SQLRender. I like to the idea to have a link or maybe even a button next to the error that will execute the query against the CDM and will show me the (top X) problematic records (with an export function). This can be in the Achilles Heel report/sheet itself or maybe we can have a simple Shiny-App the can do this using R and all the nice tools we have there.. |
The new Shiny app addresses these ideas, closing this ticket, but if there are ideas on how to improve the Shiny app, please feel free to open a new issue. |
Cleans up Achilles Heel including
Overlaps with @alondhe recent efforts.
The text was updated successfully, but these errors were encountered: