Clear coat #192
Merged
Clear coat #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block load and save, Material struct additional data)
…t should be OK: as far as I know, Filament and OGRE shaders work in two different spaces)
Since OGRE allows having different light colors for the diffuse and specular component, but the clear coat Filament implementation does not, only the specular component is take in account in direct light contribution for the clear coat layer.
… won't compile on Metal
|
This is something very minor: Can I ask you that the shader files use tabs instead of spaces? |
Done. Sorry, I wasn't aware there was a style convention (I've seen a lot of fighting between tabs and spaces, especially in BRDF piece file) and the code taken from Filament was using spaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is based on Filament, taking inspiration from @rujialiu preliminary work.
Differently from what Filament allows, I didn't add support neither for a clear coat layer dedicated normal map nor for base layer specular color alteration. Those two features weren't in my needs, but should be quite straightforward to add.
Another subtle thing that I didn't take in account is to discriminate the clear coat lighting contribution among standard scene rendering pass and IBL rendering pass.
For having a look at Filament implementation I suggest starting from here for direct light contribution and from here for indirect lighting contribution.