fix the Paging Component for v2.2 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the OgrePaging Component compilable again
|
Do you want me to merge it right now or wait? Given that no one is using this component, the PR can be merged immediately as it won't break anything |
|
Either is fine with me, i don't think i will change it in the near future since it works for me as it is. I tested the Grid2D implementation included in the Component about a year ago with v2.1 and see no reason why it shouldn't work now with the few changes for v2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a small patch to fix the OgrePaging Component for v2.2, because i am currently using it myself. It is currently a WIP but it seems to work ok for my use case: a custom, procedural implementation of PageStrategy, PageContent and PageProvider.
I would be thankful for any hints as to what might still be missing or wrong. The Grid2D/3DPageStrategy.cpp files are currently missing the
pass->setLightingEnabled(false);and i don't really know what the best/correct way is to achieve this in v2.2.