Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunfell+oe4t deploy scripts + cboot default on R32.4.3 #80

Merged

Conversation

dwalkes
Copy link
Member

@dwalkes dwalkes commented Mar 27, 2021

Thanks for getting the repo up to date for the mender community upstream @madisongh

There are two other changes here I was thinking we may want to backport to dunfell r32.4.3 since that's our stable mender branch. They may make sense in r32.5.0 and/or gatesgarth too.

  • I'd like to move the deploy script into the demo distro since I've removed the one I had in meta-mender-community with tegra: delta updates cboot support fix mendersoftware/meta-mender-community#221
  • I think we should make the cboot-t18x the default bootloader for the tegrademo-mender distro. It's maybe not typical to put a change like this on a stable branch but since this shouldn't impact anyone's existing custom distribution and is documented clearly in the README I'd hope it would be safe. Also we've found from experience you can get into confusing situations if you use uboot or cboot-prebuilt, so making one less thing someone needs to get right in their demo setup for those still using jetson-tx2 could be useful.

dwalkes added 2 commits March 27, 2021 09:02
Since uboot slot alignment issues are tricky, unless you know what
you are doing you probably want cboot as your bootloader for TX2/mender

See discussion at OE4T/meta-mender-community#8 (comment)

Signed-off-by: Dan Walkes <danwalkes@trellis-logic.com>
Move the deploy script out of meta mender community, clean
it up to have arguments and not require running under sudo.

Move the steps from the https://github.com/OE4T/meta-tegra/wiki/Flashing-the-Jetson-Dev-Kit
page into a `setup-udev-rules` script and reference this if
deploy fails.

Signed-off-by: Dan Walkes <danwalkes@trellis-logic.com>
@dwalkes dwalkes requested a review from ichergui March 27, 2021 17:07
@ichergui
Copy link
Member

Looks good to me.
I discuss with @madisongh concerning the FIT image support for the Jetson TX2.

Copy link
Member

@ichergui ichergui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment here concerning some feature related to this change.
LGTM.

@madisongh
Copy link
Member

I tested a Mender update on a TX2 from a build before this change to a build after this change was applied, and the reboot was successful. After reboot, the mender commit failed because the upgrade_available variable in U-Boot wasn't propagated forward to the new environment (which doesn't have U-Boot and emulates that flag). The rollback also failed, though, for the same reason, so in the end the upgrade was successful.

It's probably not worth the effort to clean that up here.

@madisongh madisongh merged commit 70ff46c into OE4T:dunfell-l4t-r32.4.3 Mar 28, 2021
@dwalkes dwalkes deleted the dunfell+oe4t-deploy-scripts branch March 28, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants