Adding COMPATIBLE_SPEC support for BUP payloads #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than using sed to essentially rewrite the entire config file provided in the BSP package. Signed-off-by: Matt Madison <matt@madison.systems>
This is similar to the nv-l4t-bootloader-config script used in stock JetPack, providing a mechanism for reducing BUP payload sizes by matching up binaries that are compatible across module revisions. Signed-off-by: Matt Madison <matt@madison.systems>
which brings in support for compatibility specs during BUP processing. License text changed only due to copyright year update. The git-based development recipe is updated accordingly, bumping its PV and updating the license file checksum. Signed-off-by: Matt Madison <matt@madison.systems>
Now that we have COMPATIBLE_SPEC support in the runtime bootloader update tools, we can reduce the set of specs we need to account for in the BUP payloads we build. The specs are more closely aligned with those in the stock L4T BUP generation script. Signed-off-by: Matt Madison <matt@madison.systems>
madisongh
force-pushed
the
wip-bup-compatible-spec-support
branch
from
2c766c6 to
08ac783
Compare
|
Thanks @madisongh. I needed to use I see the logic in I'll try testing this branch with |
|
Thanks @dwalkes. Looks like I pasted in the link to the t210 version of that deb package, rather than the t186/t194 one. The script is the same in either one, though. I'll fix the link. |
Verified with jetson-agx-xavier-devkit. LGTM, thanks @madisongh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already present in the JetPack 5/R35.1.0-based branches, but was more involved for R32.7.x because:
When using the stock NVIDIA bootloader update tools, the
setup-nv-boot-controlservice will add a COMPATIBLE_SPEC line to the configuration file so that BUP payload entries either matching the actual TNSPEC or the compatible spec will be considered valid for an update. The new version of thetegra-bootloader-updatetool implements similar logic for its compatibility checks.With the above changes, the
TEGRA_BUP_SPECSsettings for all machines needed revising. In most cases, fewer specs are required, making BUP packages smaller and taking less time to build/sign.For reviewing, I'd appreciate it if someone could cross check the
setup-nv-boot-control.shchanges here (and the translation of the logic in that script to the C code here in tegra-boot-tools) to derive the compatible spec string against NVIDIA's implementation in theirnv-l4t-bootloader-config.shscript. To get a copy of the NVIDIA script, extract it from thenvidia-l4t-initpackage, which you can download here, with:The relevant function in that script is called
generate_compatible_spec_info.