Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/post-service] 게시글 API 테스트코드 작성 #56

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

dldmsql
Copy link
Member

@dldmsql dldmsql commented Mar 22, 2023

No description provided.

@dldmsql dldmsql added docs 문서 수정 test 테스트 코드 labels Mar 22, 2023
@dldmsql dldmsql self-assigned this Mar 22, 2023
@github-actions
Copy link

Unit Test Results

22 tests   22 ✔️  5s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit 452295a.

제작 <5do2chonri@gmail.com> +
제작일 2023-03-23 +

*해당 문서는 주말의 집을 제작하는 오도리 팀에게 있으며, 무단 배포/변형을 금지합니다.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋있다...

<div class="paragraph">
<p>Unresolved directive in user.adoc - include::/Users/dldmsql/github/jhouse/jhouse_server/build/generated-snippets/check-sms/http-request.adoc[]
===== Response
Unresolved directive in user.adoc - include::/Users/dldmsql/github/jhouse/jhouse_server/build/generated-snippets/check-sms/http-response.adoc[]</p>
Copy link
Contributor

@MoonMinHyuk1 MoonMinHyuk1 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 실행 시 문자가 계속 보내질까봐 주석처리 해놨는데, 요건 테스트 코드가 안돌아가서 삭제된 걸까요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아!!! 그런 거 같아요. 제 로컬에서는 실행하지 않은채 문서화가 되어서 저렇게 된 거 같습니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 확인했습니다! adoc파일을 gitignore에 추가해야하나...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠... 그래야 할 거 같기도 하고.. 근데 그러면 html 파일이 생성이 안되지 않을까 싶기도 합니당

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅠㅜ방법 한 번 생각해보겠습니다!

<div class="paragraph">
<p>Unresolved directive in user.adoc - include::/Users/dldmsql/github/jhouse/jhouse_server/build/generated-snippets/check-sms/http-request.adoc[]
===== Response
Unresolved directive in user.adoc - include::/Users/dldmsql/github/jhouse/jhouse_server/build/generated-snippets/check-sms/http-response.adoc[]</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 확인했습니다! adoc파일을 gitignore에 추가해야하나...

@dldmsql dldmsql merged commit 99c46bf into dev Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 문서 수정 test 테스트 코드
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants