-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/post-service] 자유게시판, 홍보 게시판, 오도이촌 소개 페이지 CRUD 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
적어주신 Notice에 대해선 1, 3번은 저희끼리 이야기 해보면 좋을 것 같고, 2번은 기획팀에 여쭤보는게 좋을 것 같습니다!
정말 고생하셨습니다~!
src/main/kotlin/com/example/jhouse_server/domain/ads/controller/AdPostController.kt
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/domain/intro/service/IntroPostServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/global/util/SqlFunctionsMetadataBuilderContributor.kt
Show resolved
Hide resolved
YoonTaeMinnnn
approved these changes
Feb 28, 2023
src/main/kotlin/com/example/jhouse_server/domain/ads/dto/AdsPostCreateReqDto.kt
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/domain/ads/repository/AdsPostRepository.kt
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/domain/ads/dto/AdsPostCreateReqDto.kt
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/domain/ads/service/AdsPostServiceImpl.kt
Show resolved
Hide resolved
src/main/kotlin/com/example/jhouse_server/domain/intro/entity/IntroPost.kt
Show resolved
Hide resolved
1번의 경우 은비님이 말씀하신대로 soft delete 방식으로 시도해보는게 좋을꺼같아요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
추가 사항
각 게시판에서 사용하는 말머리 값을 code, name 형식으로 자바의 enum 타입으로 관리하고 있습니다. 프론트엔드 측에서 해당 데이터를 직접 입력하기 보다는 디비에서 조회해서 관리하는 편이 앞으로 관리 측면에서 효율적이지 않을까 합니다.!