Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 빈집거래 게시글 생성 API 명세서 바뀜에 따라 코드 수정 #229

Merged
merged 2 commits into from
Feb 12, 2024
Merged

feat: 빈집거래 게시글 생성 API 명세서 바뀜에 따라 코드 수정 #229

merged 2 commits into from
Feb 12, 2024

Conversation

JunJongHun
Copy link
Member

@JunJongHun JunJongHun commented Jan 1, 2024 •
edited
Loading

📖 개요

  • 빈집거래 게시글 생성 API 명세가 바뀜에 따라 프론트 코드 수정

💻 작업사항

  • 빈집거래 TYPE에 detail 속성 추가
  • UI 추가

💡 이슈

빈집거래 게시글 등록 안되는 이슈

[ 내용 ]

  1. 빈집거래 게시글 작성시 필수 값을 작성 안할 시 alert 창이 뜬다
  2. 이후 다시 요청을 보내면 게시글 생성 요청이 안감.

[해결]

  • state관리가 제대로 되지 않았음!
  • de122f6 <- 커밋 참고

✔️ check list

  • 작성한 이슈의 내용을 전부 적용했나요?
  • 리뷰어를 등록했나요?

@JunJongHun JunJongHun added the FEAT 새로운 기능 추가 label Jan 1, 2024
@JunJongHun JunJongHun self-assigned this Jan 1, 2024
@JunJongHun JunJongHun linked an issue Jan 1, 2024 that may be closed by this pull request
[feat] 빈집거래 글 작성 API 수정하기 ( detail 값 추가 ) #228
Closed
1 task
@JunJongHun JunJongHun marked this pull request as ready for review January 1, 2024 14:54
sangminlee98
sangminlee98 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@sangminlee98 sangminlee98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상세주소 추가된 것 확인했습니다 :) LGTM👍

@JunJongHun JunJongHun merged commit 88e882e into develop Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangminlee98 sangminlee98 sangminlee98 approved these changes

Assignees

@JunJongHun JunJongHun

Labels
FEAT 새로운 기능 추가
Projects
주말내집 FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 빈집거래 글 작성 API 수정하기 ( detail 값 추가 )
2 participants
@JunJongHun @sangminlee98